Update TypeScript configurations for tests & source #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our integration tests used inconsistent imports for referencing source. To avoid that, add TS aliases to allow it to import files from the sdk and vended tools I also refactored tsc type-checking to use separate config files for each of our directories and fixed the corresponding typecheck issues.
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
approved these changes
Dec 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, our integration tests used inconsistent imports for referencing source. To avoid that, add TS aliases to allow it to import files from the sdk - this is only available for integration tests, not normal tests.
I also refactored tsc type-checking to use separate config files for each of our directories and fixed the corresponding typecheck issues - previously our integ tests were not being type-checked, now they are.
Related Issues
N/A
Type of Change
Test Refactor
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.