Update exports to account for CJS #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the package exports to account for CommonJS-style imports (
require(...)).Per my research into #310 via https://nodejs.org/api/packages.html#conditional-exports:
Rather than duplicating imports for
importandrequire, we'll juse usedefault; in the future we can decide if we need specific imports for different modules, but right now we can support both.I also updated it to put
typesfirst, as [the documentation]("default"- the generic fallback that always matches. Can be a CommonJS or ES module file. This condition should always come last.) indicates it should be:Notes
testRelated Issues
#310
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.