Skip to content

remove thread pool wrapper #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pgrayy merged 2 commits into from
Jul 3, 2025
Merged

remove thread pool wrapper #339

pgrayy merged 2 commits into from
Jul 3, 2025

Conversation

@pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 2, 2025 •
edited
Loading

Description

Remove ThreadPoolWrapper as it is not offering any additional functionality on top of concurrent.futures.ThreadPoolExecutor.

Documentation PR

strands-agents/docs#117

Type of Change

  • Bug fix
  • New feature
  • Breaking change: Unlikely but possible. For more details, see comments in diff.
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy temporarily deployed to auto-approve July 2, 2025 18:13 — with GitHub Actions Inactive
@pgrayy pgrayy mentioned this pull request Jul 2, 2025
Merged
12 tasks
pgrayy
pgrayy commented Jul 2, 2025
View reviewed changes
@pgrayy pgrayy marked this pull request as ready for review July 2, 2025 18:23
zastrowm
zastrowm previously approved these changes Jul 2, 2025
View reviewed changes
@pgrayy pgrayy temporarily deployed to auto-approve July 3, 2025 01:09 — with GitHub Actions Inactive
@pgrayy pgrayy merged commit 52677ab into strands-agents:main Jul 3, 2025
12 checks passed
@pgrayy pgrayy mentioned this pull request Jul 3, 2025
Closed
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
@pgrayy @jsamuel1
remove thread pool wrapper (strands-agents#339)
f272ae3
@pgrayy pgrayy mentioned this pull request Jul 11, 2025
Closed
@pgrayy pgrayy deleted the thread_pool branch July 14, 2025 13:18
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
@pgrayy @dbschmigelski
remove thread pool wrapper (strands-agents#339)
0fe6369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zastrowm zastrowm zastrowm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgrayy @zastrowm