generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 548
Remove toolResult message when toolUse is missing due to pagination in session management #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
afarntrog
merged 4 commits into
strands-agents:main
from
afarntrog:fix_session_missing_toolUse
Dec 4, 2025
Merged
Remove toolResult message when toolUse is missing due to pagination in session management #1274
afarntrog
merged 4 commits into
strands-agents:main
from
afarntrog:fix_session_missing_toolUse
Dec 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bergjaak
approved these changes
Dec 1, 2025
zastrowm
requested changes
Dec 2, 2025
zastrowm
approved these changes
Dec 4, 2025
bergjaak
approved these changes
Dec 4, 2025
pgrayy
approved these changes
Dec 4, 2025
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
…manager (strands-agents#1274) * Remove toolUse message when its missing due to pagination in session manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the robustness of session message history handling in the
repository_session_managerby enhancing the logic for fixing broken tool use/result pairs and adding comprehensive tests for these scenarios. The changes ensure that message histories do not contain orphaned tool results, which could otherwise lead to invalid conversation states. Additionally, new tests are introduced to verify the correctness of the helper functions and the updated fixing logic.Session message history fixes:
_fix_broken_tool_usemethod inrepository_session_manager.pyto remove orphanedtoolResultmessages at the start of the conversation and clarified the docstring to explain the handling of both orphanedtoolUseandtoolResultmessages._fix_broken_tool_usefor clarity.Testing improvements:
test_repository_session_manager.pyto verify that orphanedtoolResultmessages at the start are removed and that normal conversations are unaffected by the fixing logic.test_tool_helpers.pywith tests for thegenerate_missing_tool_result_contentfunction, ensuring correct generation of missing tool results for various scenarios.Related Issues
#1272
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.