This repository was archived by the owner on Jul 13, 2023. It is now read-only.
fix: authority parsing #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
approved these changes
Jun 5, 2019
| }, | ||
| "devDependencies": { | ||
| "@stoplight/scripts": "5.1.0", | ||
| "@stoplight/scripts": "7.0.0", |
There was a problem hiding this comment.
Make sure everything important is exported in the main entry point.
| // could not parse... roll back to original value | ||
| lookupResult.resolved.result = val; | ||
|
|
||
| lookupResult.error = { |
There was a problem hiding this comment.
Shouldn't we leave this error out?
There was a problem hiding this comment.
The error is still captured as part of the RESOLVE_AUTHORITY error (see change in tests related to this).
There was a problem hiding this comment.
Yeah I saw the test was updated, but what if the parseAuthority function throws? Shouldn't we set the former error?
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
marbemac
added a commit
that referenced
this pull request
Jun 26, 2019
This reverts commit fb79a2c. # Conflicts: # package.json # yarn.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parseAuthorityhook used to run after the lookup attempt for a pointer, e.g.#/foo. If the target document returned from the authority was not json already, this lookup would fail. This PR makes it so that parseAuthority runs right after the authority target is fetched, before lookup, fixing the problem.