I2C multi instances: Remove static qualifier on TwoWire attributes #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I2C buffers, as well as some other attributes of the TwoWire class, should not be static (shared between instances), otherwise multi instance I2C doesn't work properly. For example when MCU is master on one instance and slave on the other, Slave reception under interruption can happen in the middle of master transmission, and there is conflict on the shared resources. fixes stm32duino#699
fpistm
requested changes
Jan 30, 2020
With introduction of 'I2C multi instances: Remove static qualifier on TwoWire attributes' parameters 'inBytes' and 'numBytes' become useless as they are part of new obj structure parameter.
fpistm
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I2C buffers, as well as some other attributes of the TwoWire class,
should not be static (shared between instances),
otherwise multi instance I2C doesn't work properly.
For example when MCU is master on one instance and slave on the other,
Slave reception under interruption can happen in the middle of master transmission,
and there is conflict on the shared resources.
fixes #699