Skip to content

Added Generic flight controllers Sub menu #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

darkspr1te
Copy link
Contributor

Added basic Afroflight Rev 5 board variant
Added generic flight controller menu only
Added build options only
116b1c2

@fpistm
Copy link
Member

fpistm commented Jul 24, 2019

You can refers to this to help on applying asrtyle:
https://github.com/stm32duino/wiki/wiki/Astyle

@fpistm fpistm self-requested a review July 30, 2019 07:14
@fpistm
Copy link
Member

fpistm commented Aug 22, 2019

Hi @darkspr1te
could you update your PR with my comments?
Thanks

@fpistm fpistm added new variant Add support of new bard Review on going waiting feedback Further information is required labels Aug 22, 2019
@fpistm fpistm added this to the 1.7.0 milestone Aug 22, 2019
@fpistm
Copy link
Member

fpistm commented Aug 23, 2019

@darkspr1te
please remove all couple of :

#ifndef ARDUINO_BLUEPILL_F103C6
#endif 

and the last 2 astyle issues:

diff --git a/variants/AFROFLIGHT_F103CB/variant.cpp b/variants/AFROFLIGHT_F103CB/variant.cpp
index 30abde0..22f1b30 100644
--- a/variants/AFROFLIGHT_F103CB/variant.cpp
+++ b/variants/AFROFLIGHT_F103CB/variant.cpp
@@ -104,7 +104,7 @@ extern "C" {
   */
 WEAK void SystemClock_Config(void)
 {
-//Board has 12mhz xtal, iám currenlty using HSI internal xtal , i've not figured settings for external 12mhz
+  //Board has 12mhz xtal, iám currenlty using HSI internal xtal , i've not figured settings for external 12mhz
   RCC_OscInitTypeDef RCC_OscInitStruct;
   RCC_ClkInitTypeDef RCC_ClkInitStruct;
   RCC_PeriphCLKInitTypeDef PeriphClkInit;
diff --git a/variants/AFROFLIGHT_F103CB/variant.h b/variants/AFROFLIGHT_F103CB/variant.h
index 4eb69af..5b5ffc5 100644
--- a/variants/AFROFLIGHT_F103CB/variant.h
+++ b/variants/AFROFLIGHT_F103CB/variant.h
@@ -153,7 +153,7 @@ extern "C" {
  * BEEP        PA12; //Connected to Beep out transistor on 6 pin header
  *
  */
-  
+
 #ifdef __cplusplus
 } // extern "C"
 #endif

It seems you do not take in account all my review ( comments to remove,...)

fpistm and others added 4 commits August 23, 2019 10:02
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Handle 8 and 12 MHz HSE values
@fpistm fpistm removed Review on going waiting feedback Further information is required labels Aug 28, 2019
@fpistm
Copy link
Member

fpistm commented Aug 28, 2019

Replaced by #616

@fpistm fpistm closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants