Handle 8 and 12 MHz HSE values #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic.Pillon <[email protected]>
|
Did you test it? |
|
yes, working fine with my setup but not with the new offical core, i need to check on that later, could be a conflict with my local base as I am also trying to port some of the functions from other stmduino cores so often run sandboxed setups that are not full environments. the symptom is hanging when using hardware timers. Again, could be a issue with my multi core setup or the newly added h/w timers, my test projects use h/w timers but from my own code base, |
|
ok |
|
Issue resolved and it was with my local code. 8mhz and 12mhz works on both my official boards (8/12mhz external xtal only). This will cover a lot of cleanflight based boards on the current market. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @darkspr1te
This PR handle 8 and 12MHz system clock config.
If you can test and think it is OK then you can merge in your branch and I will be able to merge your PR in official repo.
Thanks in advance for your feedback.