Fix LINKFLAGS containing a tuple in platformio build script #2751
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Stary2001 |
fifieldt
approved these changes
Jun 10, 2025
|
Hi guys, thanks for pinging. @Stary2001 Could you please share a project to reproduce the issue? |
Stary2001
added a commit
to Stary2001/pio-project-for-pr-2751
that referenced
this pull request
Jun 13, 2025
|
@valeros I've made a simple reproducer here - https://github.com/Stary2001/pio-project-for-pr-2751 The extra script they use is here: https://github.com/boschsensortec/Bosch-BSEC2-Library/blob/master/extra_script.py#L18 - it iterates over LINKFLAGS to find the mcpu= argument that's being used. |
|
@Stary2001 thanks for a detailed reply. I've pushed your fix to PlatformIO registry. @fpistm Feel free to merge the PR. |
github-project-automation
bot
moved this from In progress
to Done
in STM32 core based on ST HAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the platformio build script where a tuple containing the arguments is placed into LINKFLAGS. This broke a custom script in a different project (Bosch BSEC2 sensor library) that looks at LINKFLAGS.
I'm not sure how it worked before..
I've tested this locally and it's a minor change.