Skip to content

remove NoPin, use Option #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

remove NoPin, use Option #813

merged 1 commit into from
Jun 9, 2025

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull force-pushed the none branch 2 times, most recently from c16487e to d48038b Compare June 9, 2025 16:07
@burrbull burrbull marked this pull request as ready for review June 9, 2025 16:08
@burrbull burrbull requested a review from a team June 9, 2025 19:37
therealprof
therealprof approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I'm wondering how we came up with the NoPin concept to begin with.

@burrbull
Copy link
Member Author

burrbull commented Jun 9, 2025

I like it. I'm wondering how we came up with the NoPin concept to begin with.

  1. There were NoSck implementing PinSck trait, NoMiso, etc.
  2. Then I added common NoPin when generic Pin was introduced.
  3. When alternate pin enums were added I was forced to add NoPin variant to that enums just because I could not find better solution.

Option based way is also not ideal as None can't infer its type. That is why SPIx::NoMiso and relatives were added.
But it is definitely better than NoPin enum variant.

@burrbull burrbull added this pull request to the merge queue Jun 9, 2025
Merged via the queue into master with commit 0584201 Jun 9, 2025
22 checks passed
@burrbull burrbull deleted the none branch June 9, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof