Skip to content

Conversation

@Disasm
Copy link
Member

@Disasm Disasm commented Nov 20, 2020

This should prevent terrible user experience when SYSCFG is used without its clock enabled.

Note that this is a breaking change.

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Thanks.

But continuing on with tradition this is lacking a CHANGELOG.md entry. 😅

@Disasm
Copy link
Member Author

Disasm commented Nov 20, 2020

@therealprof fixed :) I should probably pull a changelog requirement CI rule from probe-rs.

@therealprof
Copy link
Member

@therealprof fixed :) I should probably pull a changelog requirement CI rule from probe-rs.

Such a thing exists? That'd be a great addition to all WG repos...

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

bors r+

@Disasm
Copy link
Member Author

Disasm commented Nov 20, 2020

https://github.com/probe-rs/probe-rs/pull/428/files
However, it uses secrets.GITHUB_TOKEN, I'm not sure why. Probably needs additional setup.

@bors bors bot merged commit 4b04112 into stm32-rs:master Nov 20, 2020
@Disasm Disasm deleted the fix-syscfg branch November 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants