Skip to content

Conversation

@torkeldanielsson
Copy link
Contributor

I suggest using cargo fmt (rustfmt) to format the code.
Or is there some reason this is not done in this crate?

(This PR only does cargo fmt.)

@therealprof
Copy link
Member

therealprof commented Apr 23, 2020

@torkeldanielsson Well, rustfmt and its capabilities changed quite a bit over time (e.g. the abilitiy to (partially) format within macro blocks). Also some people are not too excited about the default rustfmt formatting rules for PAC uses.

For me this is a clear improvement and I'd be in favour of that but I'll let other people with a stronger opinion chime in and reach a verdict on this PR.

Copy link
Contributor

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. I prefer fmted code.

To merge this, the ci must check if the code is formatted.

@TheZoq2
Copy link
Member

TheZoq2 commented Apr 26, 2020

Sounds like a good change. Most fmt changes look reasonable and having a consistent style is nice (even though I hate the tie fighter else) As @TeXitoi said, it's probably best if CI checks if the formatting is done correctly

@therealprof
Copy link
Member

For me doing that seems a good follow up step. Since we're all in agreement, let's get this merged.

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof therealprof merged commit 1357e5a into stm32-rs:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants