Revert strict mode #911
Merged
Revert strict mode #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2024 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Strict mode implementation is incomplete, but we need to schedule the next release. To prevent something like this from happening in the future, features won't be accepted until they are fully completed.
The commits being reverted are: #888, #886, #877
Does the code still compile with Java6?
Yes
Risks
Moderate - code and behavior is being reverted, but it was opt-in, and I don't think widely used. The code being reverted has not been released.
Changes to the API?
Yes
Will this require a new release?
Yes
Should the documentation be updated?
No
Does it break the unit tests?
No, unit tests for strict mode have also been removed.
Was any code refactored in this commit?
No
Review status
APPROVED - by myself
Starting 7-day comment window