Skip to content

fix: get project compiled on msvc and clang #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: get project compiled on msvc and clang #7

wants to merge 2 commits into from

Conversation

@FelixPetriconi
Copy link
Member

@FelixPetriconi FelixPetriconi commented Nov 4, 2025

  • silence shadowing because that happens a lot in future.hpp
  • mark variables as maybe_unused because msvc complains in unused case of constexpr branch
  • enable __cplusplus makro for msvc because it is used inside the future library but not enabled by default

@FelixPetriconi
fix: get project compiled on msvc and clang
e63636e 
* silence shadowing because that happens a lot in future.hpp
* mark variables as maybe_unused because msvc complains in unused case
  of constexpr branch
* enable __cplusplus makro for msvc because it is used inside the
  future library but not enabled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-parent sean-parent Awaiting requested review from sean-parent

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FelixPetriconi