Fix for JS Syntax Errors #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So now the transforms are executed after each build
because I caused null references with the last one!
Also fixed code coverage issue
Added a build script to create the nuget package for the main ProxyApi project
Added a nuspec file for intellisense package
The T4 template used to append commas (',') in the two foreach loops.
This is invalid syntax for JSON objects. I switched the foreach loops to
for loops and put a condition before writing the commas out.
I also made the template generate better formatted js, but unfortunately
this has caused the T4 template to be harder to read - it seems white
space before conditional T4 blocks is included in the output
unfortunately
Owner
|
Hi @marlon-tucker, I agree with the removal of commas (I'll try to get that merged in) but personally I think I would prefer readability in the code I am working on rather than in the generated code. |
Author
|
yep that's fair enough, cheers for the reply. I am having issues with the MVC project I'm using having multiple 'areas' within it, are you aware of any issues with areas or should I submit a bug ticket? The namespaces aren't resolving correctly to the correct URLs. |
Owner
|
I haven't tested it with multiple areas so create an issue and .I'll look at it when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The T4 template used to append commas (',') in the two foreach loops regardless if the current element was the last element in the sequence. This is invalid syntax for JSON style objects. I switched the foreach loops to
for loops and put a condition before writing the commas out.
It does seem most browsers are clever enough to ignore this sort of syntax error, but I have the JavaScript Parser VS plugin to aid web dev, and it wasn't happy with the generated inteliisense files.
I also made the template generate better formatted js, but unfortunately
this has caused the T4 template to be harder to read - it seems white
space before conditional T4 blocks is included in the output
unfortunately