rtl_test: Refactoring and optimization for PPM error measurement. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the duplicate |
|
Ups |
|
Thanks for the patch. What is 'interaval' supposed to mean, is that a global typo (interval)? |
|
Yes, it's 'interval'. |
|
After talking with Kyle Keen I working on some improvements. It's not final version now. |
Part 2. Thanks to Kyle Keen.
Part 3. Added states for ppm_init.
|
It's final. Steve, are you add it? |
|
I don't like the defines in the middle of the code (PPM_INIT_NO etc.), could you put those above the function? Also, you used an enum for test_mode, why not use an enum here as well? |
Part 4. Use an enum for ppm_init state.
|
Good idea. Fixed. |
|
More questions? |
|
Okay, I've merged your changes. I changed some small things though, like adding missing 'static' storage modifiers, and removed the cast to long by reverting to uint32_t for total_samples and dropped_samples. |
|
Thanks! |
paulyc
pushed a commit
to paulyc/librtlsdr
that referenced
this pull request
May 31, 2019
rtl_tcp option '-l' for to set block length in units of 512 samples
tadscottsmith
pushed a commit
to tadscottsmith/librtlsdr
that referenced
this pull request
Jan 11, 2023
…mber Remove a magic number or two from the VGA gain settings.
steve-m
pushed a commit
that referenced
this pull request
Dec 7, 2023
…lo/rtl-sdr:libusb-pkgconfig into master Reviewed-on: https://gitea.osmocom.org/sdr/rtl-sdr/pulls/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
after talking with keenerd I removed the windows port