Skip to content

Remove try! statement from FailableIterator #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove try! statement from FailableIterator #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d84e9
Remove try! statement from FailableIterator
ethansinjin Mar 8, 2018
bc92116
Merge branch 'master' into patch-1
ethansinjin Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/SQLite/Core/Statement.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ public protocol FailableIterator : IteratorProtocol {

extension FailableIterator {
public func next() -> Element? {
return try! failableNext()
if let next = try? failableNext() {
Copy link
Contributor

@0xced 0xced Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could simply write return try? failableNext() instead of return try! failableNext(). There's no need to use if let here.

Copy link

@gsabran gsabran May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this raises Value of optional type 'Self.Element??' not unwrapped; did you mean to use 'try!' or chain with '?'?

return next
}
return nil
}
}

Expand Down