[CocoaPods] Add SQLite module map for each architecture #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggy-backing off of #380
☝️ What does this PR do?
This fixes the build problem where people were unable to build depending on what version of Xcode they were using. I know, it sounds bizarre...
✌️ How does it do it?
I split up the module maps up by architecture, and imported them in the private build settings (basically the same technique I mentioned in this comment)
📖 More Information!
While I was investigating, I downloaded both versions of Xcode (dmg and AppStore). The dmg version was fine. The AppStore version would build for devices, but not for the simulator. But! If I rearranged the order of the
x86
,arm
,arm64
modules, I could get it to succeed/fail in building in the other way around!So I thought, I don't know which version of Xcode is correct, but one of them is certainly buggy. But it would be better if it would build for anyone regardless of what version of Xcode they were using.
Yeah, it's a little disappointing to have more files like this to take care of, but I couldn't find another way to make a kind of 'conditional import'.
Plus! I've gotten it to successfully build on CircleCI, so that make me feel a little bit better! 😄