use actioncommit map for pining #2540
Open
+127
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkurmi
approved these changes
Oct 16, 2025
ashishkurmi
reviewed
Oct 16, 2025
| if err != nil { | ||
| return inputYaml, updated | ||
| } | ||
| if actionCommitMap != nil && actionCommitMap[action] != "" { |
There was a problem hiding this comment.
Are GitHub Action references case sensitive? If not, this will not work in case the action is referenced in different case (e.g., actionorg/actionname@v2 and ActionOrg/Actionname@v2 will be treated differently in the current appraoch). If GitHub Action references are case insensitive, we should create a struct and perform case insensitive comparison on action name and/or version tag or use lowercase to create the map and look up operation.
There was a problem hiding this comment.
yes they are case sensitive @ashishkurmi
mkdocs/mkdocs#3567
https://github.com/orgs/community/discussions/27086
only secret names are are case insensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.