-
-
Notifications
You must be signed in to change notification settings - Fork 839
feat!: migrate utils/some-in-by
to object/some-in-by
#7376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit removes `@stdlib/utils/some-in-by` in favor of `@stdlib/object/some-in-by`. BREAKING CHANGE: remove `utils/some-in-by` To migrate, users should update their require/import paths to use `@stdlib/object/some-in-by` which provides the same API and implementation. Ref: stdlib-js#7372
Coverage Report
The above coverage report was generated for the changes in this PR. |
@kgryte
|
I believe there is an existing bug in |
Not a bug; just incomplete tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Neerajpathak07 In the future, you want to do these migrations one package at a time and not have multiple PRs; otherwise, merging one will cause merge conflicts in the others. I'll work through the current PRs, but we'll need to adopt a sequential approach to reduce review/merge overhead. |
Resolves #7372.
Description
This pull request:
utils/some-in-by
toobject/some-in-by
Related Issues
This pull request:
utils/some-in-by
toobject/some-in-by
#7372Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers