Skip to content

feat!: migrate utils/some-in-by to object/some-in-by #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves #7372.

Description

What is the purpose of this pull request?

This pull request:

  • migrates utils/some-in-by to object/some-in-by

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit removes `@stdlib/utils/some-in-by` in favor of
`@stdlib/object/some-in-by`.

BREAKING CHANGE: remove `utils/some-in-by`

To migrate, users should update their require/import paths to use
`@stdlib/object/some-in-by` which provides the same API and implementation.

Ref: stdlib-js#7372
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 16, 2025
@Neerajpathak07 Neerajpathak07 added the release: Major Breaking change requiring a new major release. label Jun 16, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/alias2standalone $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/pkg2alias $\color{green}100/100$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2related $\color{green}100/100$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2standalone $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/standalone2pkg $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
object/some-in-by $\color{red}132/133$
$\color{green}+99.25\%$
$\color{red}13/14$
$\color{green}+92.86\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{red}132/133$
$\color{green}+99.25\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jun 16, 2025

@Neerajpathak07 Neerajpathak07 requested a review from kgryte June 16, 2025 15:47
@Neerajpathak07
Copy link
Member Author

I believe there is an existing bug in some-in-by package similar coverage was also obtained in this PR:- #5745

@kgryte
Copy link
Member

kgryte commented Jun 26, 2025

Not a bug; just incomplete tests.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 26, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit d27d963 into stdlib-js:develop Jun 26, 2025
51 checks passed
@kgryte
Copy link
Member

kgryte commented Jun 26, 2025

@Neerajpathak07 In the future, you want to do these migrations one package at a time and not have multiple PRs; otherwise, merging one will cause merge conflicts in the others. I'll work through the current PRs, but we'll need to adopt a sequential approach to reduce review/merge overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: Major Breaking change requiring a new major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: migrate utils/some-in-by to object/some-in-by
3 participants