feat: add C implementation for `stats/base/dists/normal/mgf` #4373

0PrashantYadav0 · 2024-12-30T06:56:29Z

Resolves #3778

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/normal/mgf along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/normal/mgf #3778

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

PR-URL: stdlib-js#4110 Reviewed-by: Athan Reines <[email protected]> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

…nto develop --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…nto develop --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2024-12-30T06:58:41Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/normal/mgf	$\color{green}293/293$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}293/293$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

0PrashantYadav0 · 2025-02-17T16:10:08Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Planeshifter

Thanks, @0PrashantYadav0 for your PR. Left a bunch of comments that should be resolved.

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/benchmark.native.js

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/examples/c/example.c

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/src/main.c

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/manifest.json

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/examples/c/example.c

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/benchmark.native.js

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

Thanks for all your efforts, @0PrashantYadav0!

stdlib-bot · 2025-03-07T03:46:37Z

PR Commit Message

feat: add C implementation for `stats/base/dists/normal/mgf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4373
Closes: https://github.com/stdlib-js/stdlib/issues/3778

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

Neerajpathak07 and others added 5 commits December 27, 2024 23:49

Merge branch 'stdlib-js:develop' into develop

e9f48a5

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 30, 2024

Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 9, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 9, 2025

chore: update copyright years

f2a2a4b

Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 9, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

Merge remote-tracking branch 'upstream/develop' into normal/mgf

4ba442a

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

Planeshifter requested changes Feb 18, 2025

View reviewed changes

0PrashantYadav0 requested a review from Planeshifter February 18, 2025 10:04

0PrashantYadav0 added 3 commits February 18, 2025 15:35

Planeshifter reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md Show resolved Hide resolved

Planeshifter reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/examples/c/example.c Outdated Show resolved Hide resolved

Planeshifter reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/benchmark.native.js Outdated Show resolved Hide resolved

chore: apply suggestions from code review

b04670f

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter approved these changes Mar 7, 2025

View reviewed changes

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 7, 2025

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025

Planeshifter merged commit aec0e88 into stdlib-js:develop Mar 7, 2025
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `stats/base/dists/normal/mgf` #4373

feat: add C implementation for `stats/base/dists/normal/mgf` #4373

Uh oh!

0PrashantYadav0 commented Dec 30, 2024

Uh oh!

stdlib-bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

0PrashantYadav0 commented Feb 17, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Mar 7, 2025 •

edited by Planeshifter

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: add C implementation for stats/base/dists/normal/mgf #4373

feat: add C implementation for stats/base/dists/normal/mgf #4373

Uh oh!

Conversation

0PrashantYadav0 commented Dec 30, 2024

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

0PrashantYadav0 commented Feb 17, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 7, 2025 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Uh oh!

feat: add C implementation for `stats/base/dists/normal/mgf` #4373

feat: add C implementation for `stats/base/dists/normal/mgf` #4373

stdlib-bot commented Dec 30, 2024 •

edited

Loading

stdlib-bot commented Mar 7, 2025 •

edited by Planeshifter

Loading