Skip to content

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #3332 .

Description

What is the purpose of this pull request?

This pull request:

  • This RFC proposes adding the package @stdlib/constants/float32/ln-half returning Natural Logarithm of single-precision floating-point number 1/2.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

vivekmaurya001 and others added 20 commits December 3, 2024 17:14
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2024
@vivekmaurya001 vivekmaurya001 changed the title feat: add constants/float32/sqrt-two feat: add constants/float32/ln-half Dec 5, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 5, 2024

Coverage Report

Package Statements Branches Functions Lines
constants/float32/ln-half $\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gunjjoshi
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 6, 2024
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 6, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 6, 2024
@kgryte kgryte changed the title feat: add constants/float32/ln-half feat: add constants/float32/ln-half Dec 11, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 11, 2024
Signed-off-by: Athan <[email protected]>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @vivekmaurya001.

@kgryte kgryte added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Dec 13, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/ln-half`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3333
Closes: https://github.com/stdlib-js/stdlib/issues/3332

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: Vivek Maurya <[email protected]>
Co-authored-by: Vivek maurya <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 5a4f6ed into stdlib-js:develop Dec 13, 2024
19 checks passed
@vivekmaurya001 vivekmaurya001 deleted the float32/ln-half branch January 1, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/ln-half
4 participants