Skip to content

feat: add REPL text lint rule to catch semicolon omission in examples #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

feat: add REPL text lint rule to catch semicolon omission in examples #2435

merged 1 commit into from
Jun 22, 2024

Conversation

Snehil-Shah
Copy link
Member

Resolves #2428

Description

What is the purpose of this pull request?

This pull request:

  • add REPL text lint rule to catch semicolon omission in cases where the output is suppressed

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah Snehil-Shah added Tools Issue or pull request related to project tooling. REPL Issue or pull request specific to the project REPL. labels Jun 22, 2024
kgryte
kgryte approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte merged commit 22b415c into stdlib-js:develop Jun 22, 2024
@Snehil-Shah Snehil-Shah mentioned this pull request Jul 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
REPL Issue or pull request specific to the project REPL. Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add REPL text lint rule for catching semicolon omission in examples
2 participants
@Snehil-Shah @kgryte