-
-
Notifications
You must be signed in to change notification settings - Fork 878
feat: add utils/none-in-by
#1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add utils/none-in-by
#1416
Conversation
Check whether every property of object does not satisfy predicate function Fixes stdlib-js#824
lib/node_modules/@stdlib/utils/none-in-by/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change Copyright years wherever it is necessary.
applied all suggested changes Fixes stdlib-js#824
fixed the bug in function execution test Fixes stdlib-js#824
fixed the bug in function execution test Fixes stdlib-js#824
@Jaysukh-409 I have made all suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs a few changes, I have requested changes and ask you to iterate over entire package comparing against stdlib/utils/none-by
. Thank you!
@Pranavchiku I have completed the suggested changes and have reviewed the whole package. |
Fixed the style in readme and added code block for function does not skip ndefines elements Fixes stdlib-js#824
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just made a few code style and documentation fixes, but otherwise this PR should be ready to land once CI clears.
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#1416 Closes: stdlib-js#824 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Reviewed-by: Jaysukh Makvana <[email protected]> Reviewed-by: Pranav Goswami <[email protected]>
Check whether every property of object does not satisfy predicate function
Fixes #824
Resolves #824 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/utils/none-in-by
#824Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers