Skip to content

Conversation

AgPriyanshu18
Copy link
Contributor

@AgPriyanshu18 AgPriyanshu18 commented Feb 29, 2024

Check whether every property of object does not satisfy predicate function

Fixes #824

Resolves #824 .

Description

What is the purpose of this pull request?

This pull request:

  • a add utils/none-in-by
  • b Check whether every property of object does not satisfy predicate function
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Check whether every property of object does not satisfy predicate function

Fixes stdlib-js#824
Copy link
Member

@Jaysukh-409 Jaysukh-409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Copyright years wherever it is necessary.

@AgPriyanshu18
Copy link
Contributor Author

@Jaysukh-409 I have made all suggested changes.

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a few changes, I have requested changes and ask you to iterate over entire package comparing against stdlib/utils/none-by. Thank you!

@AgPriyanshu18
Copy link
Contributor Author

@Pranavchiku I have completed the suggested changes and have reviewed the whole package.

@Planeshifter Planeshifter changed the title feat: added utils/none-in-by feat: add utils/none-in-by Mar 3, 2024
Fixed the style in readme and added code block for function does not skip ndefines elements

Fixes stdlib-js#824
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just made a few code style and documentation fixes, but otherwise this PR should be ready to land once CI clears.

@Planeshifter Planeshifter merged commit c9e1623 into stdlib-js:develop Mar 5, 2024
@AgPriyanshu18 AgPriyanshu18 deleted the feature/none-in-by branch March 5, 2024 08:27
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
PR-URL: stdlib-js#1416
Closes: stdlib-js#824

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Jaysukh Makvana <[email protected]> 
Reviewed-by: Pranav Goswami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/utils/none-in-by
4 participants