-
-
Notifications
You must be signed in to change notification settings - Fork 878
Description
This commit has 3 comment(s) from core contributors that require attention.
Commit: 11e8a560e234be46e49d0df96325da7b1cf36f8d
Comments:
-
Line 203: @stdlib-bot Remove extra space between
logpmf
and(
.stdlib/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/README.md
Lines 200 to 206 in 11e8a56
- **n**: `[in] int32_t` number of draws. ```c double stdlib_base_dists_hypergeometric_logpmf ( const double x, const int32_t N, const int32_t K, const int32_t n ); ``` </section> -
Line 29: @stdlib-bot Missing Oxford comma after
K
and beforeand
.stdlib/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/src/main.c
Lines 26 to 32 in 11e8a56
#include <stdint.h> /** * Evaluates the natural logarithm of the probability mass function (PMF) for a hypergeometric distribution with population size `N`, subpopulation size `K` and number of draws `n`. * * @param x input value * @param N population size -
Line 71: @stdlib-bot Should be
returns expected value
.stdlib/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/test/test.native.js
Lines 68 to 74 in 11e8a56
t.equal( y, NINF, 'returns expected value' ); y = logpmf( 100, 20, 20, 10 ); t.equal( y, NINF, 'returns -Infinity' ); t.end(); });
Interested in helping improve the project? If you are, the comment linked to above has 3 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.