Skip to content

Conversation

@saledjenic
Copy link
Contributor

With these changes we're refreshing paraswap proposal along with the fees update but at different intervals.

Using the following constants we can easily adjust the intervals per chain:

paraswapProposalCheckIntervalMainnet      = 12 * time.Second
paraswapProposalCheckIntervalOptimism     = 3 * time.Second
paraswapProposalCheckIntervalArbitrum     = 3 * time.Second
paraswapProposalCheckIntervalAnvilMainnet = 2 * time.Second

This is not an urgent thing, we agreed to have it in 2.32, but since we had a conversation about it today, I just wanted to quickly draft it.

We can improve it more later and add necessary tests.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 28, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ c1b3d0e #1 2024-10-28 17:37:40 ~1 min tests 📄log
✔️ c1b3d0e #1 2024-10-28 17:40:29 ~4 min macos 📦zip
✔️ c1b3d0e #1 2024-10-28 17:41:22 ~5 min linux 📦zip
✔️ c1b3d0e #1 2024-10-28 17:41:32 ~5 min ios 📦zip
✔️ c1b3d0e #1 2024-10-28 17:41:59 ~6 min android 📦aar
✔️ c1b3d0e #1 2024-10-28 17:42:23 ~6 min tests-rpc 📄log
✖️ c1b3d0e #1 2024-10-28 17:46:48 ~10 min windows 📦zip
✔️ c1b3d0e #1 2024-10-28 17:47:14 ~11 min macos 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 7b02858 #2 2024-10-28 17:45:13 ~2 min tests-rpc 📄log
✖️ 7b02858 #2 2024-10-28 17:46:58 ~4 min tests 📄log
✔️ 7b02858 #2 2024-10-28 17:47:49 ~4 min macos 📦zip
✔️ 7b02858 #2 2024-10-28 17:48:29 ~5 min ios 📦zip
✔️ 7b02858 #2 2024-10-28 17:48:29 ~5 min linux 📦zip
✔️ 7b02858 #2 2024-10-28 17:49:06 ~6 min android 📦aar
✔️ 7b02858 #2 2024-10-28 17:56:56 ~9 min macos 📦zip
✖️ 7b02858 #2 2024-10-28 17:57:40 ~10 min windows 📦zip
✔️ ad56b69 #3 2024-11-04 09:31:32 ~4 min ios 📦zip
✔️ ad56b69 #3 2024-11-04 09:32:16 ~4 min tests-rpc 📄log
✔️ ad56b69 #3 2024-11-04 09:32:22 ~5 min linux 📦zip
✔️ ad56b69 #3 2024-11-04 09:32:36 ~5 min windows 📦zip
✔️ ad56b69 #3 2024-11-04 09:33:00 ~5 min macos 📦zip
✔️ ad56b69 #3 2024-11-04 09:33:34 ~6 min android 📦aar
✔️ ad56b69 #3 2024-11-04 09:37:49 ~10 min macos 📦zip
✔️ ad56b69 #3 2024-11-04 10:01:09 ~33 min tests 📄log

@saledjenic saledjenic force-pushed the feat/refresh-paraswap-proposal branch from c1b3d0e to 7b02858 Compare October 28, 2024 17:42
@saledjenic saledjenic changed the title feat: refresh paraswap proposal on intervals defined per chains feat(wallet)_: refresh paraswap proposal on intervals defined per chains Nov 4, 2024
@saledjenic saledjenic force-pushed the feat/refresh-paraswap-proposal branch from 7b02858 to ad56b69 Compare November 4, 2024 09:26
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

❌ Patch coverage is 66.66667% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.83%. Comparing base (b329b15) to head (ad56b69).
⚠️ Report is 735 commits behind head on develop.

Files with missing lines Patch % Lines
services/wallet/router/router_updates.go 35.89% 25 Missing ⚠️
services/wallet/router/router.go 82.05% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6001      +/-   ##
===========================================
- Coverage    60.88%   60.83%   -0.06%     
===========================================
  Files          811      811              
  Lines       108894   108922      +28     
===========================================
- Hits         66303    66259      -44     
- Misses       34841    34891      +50     
- Partials      7750     7772      +22     
Flag Coverage Δ
functional 13.09% <46.15%> (+<0.01%) ⬆️
unit 60.19% <64.95%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/router/router.go 82.07% <82.05%> (+1.21%) ⬆️
services/wallet/router/router_updates.go 47.41% <35.89%> (-9.73%) ⬇️

... and 22 files with indirect coverage changes

@igor-sirotin
Copy link
Collaborator

@saledjenic is this still relevant?

@saledjenic
Copy link
Contributor Author

@igor-sirotin yes, it should be, but somehow, always something else is more urgent.

@alaibe
Copy link
Collaborator

alaibe commented Oct 29, 2025

Closing as it should been a year

@alaibe alaibe closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants