chore: Enable orc and use malloc on mobile #18986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
alexjba
force-pushed
the
fix/wallet-crashes
branch
4 times, most recently
from
742b60c to
f00edce
Compare
alexjba
force-pushed
the
chore/enable-orc-mobile
branch
from
b6a8b28 to
5b6e67e
Compare
alexjba
force-pushed
the
chore/enable-orc-mobile
branch
from
5b6e67e to
a9ddf8a
Compare
|
Some stats on Android. The memory usage for a new account with Status community loaded (not a member) will decrease from ±800 to ±500. Another thing I've noticed is that if we leave it to Scudo to manage the Android memory it will more efficiently release memory when the app is not visible. |
alexjba
requested review from
Khushboo-dev-cpp,
alaibe,
caybro,
noeliaSD and
saledjenic
and removed request for
iurimatias
|
@glitchminer is it possible to run the appium tests on this branch? |
caybro
approved these changes
Oct 16, 2025
dlipicar
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Enabling
orcmemory manager for nim and usemallocto allocate objects. The memory footprint for the app will decrease up to 300MB with no noticeable downsides in terms of performance.The only
downsideI've seen so far is that nim objects will be deallocated for real! Meaning that we'll need to be more careful with the lifetime management when sharing objects with QML. The advantage on the other hand is that in such a case a crash is imminent when QML tries to access the QObject.