adjust JSON marshalling tests #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs a version bump release of nim-json-rpc to pass tests (so nimble finds the new code) |
|
merge this to #209, to assist json-rpc bump |
jangko
added a commit
that referenced
this pull request
Jul 30, 2025
* On JSON-RPC, authorization serializes v as yParity JSON uses yParity for authorization instead of v like in transaction, because v for transaction has additional information mixed in in legacy case (chain ID and magic value); this legacy case is not relevant for authorizations. Existing logic ignored yParity value from JSON and uses default initialized v = 0 value. Create our own web3 type, same as how we do it for transactions and receipts, and use correct yParity key. * Fix deps * Use flavor automatic serialization * eth_api seq[string] * adjust JSON marshalling tests (#202) Co-authored-by: Jacek Sieka <[email protected]> * Custom serializer for TransactionArgs: oneof input or data field * cleanup --------- Co-authored-by: jangko <[email protected]> Co-authored-by: tersec <[email protected]> Co-authored-by: Jacek Sieka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on