-
Notifications
You must be signed in to change notification settings - Fork 822
Closed
Labels
Type: bugSomething isn't workingSomething isn't working
Description
Describe the bug
skipValidate
doesnt applied in estimateFeeBulk
method
In https://github.com/starknet-io/starknet.js/blob/v6.6.0/src/account/default.ts#L260
we may fix the code in
public async estimateFeeBulk(
invocations: Invocations,
details: UniversalDetails = {}
): Promise<EstimateFeeBulk> {
const { nonce, blockIdentifier, version, skipValidate } = details;
const accountInvocations = await this.accountInvocationsFactory(invocations, {
...v3Details(details),
versions: [
ETransactionVersion.F1, // non-sierra
toTransactionVersion(
this.getPreferredVersion(ETransactionVersion.F2, ETransactionVersion.F3),
version
), // sierra
],
nonce,
blockIdentifier,
skipValidate,
});
return super.getEstimateFeeBulk(accountInvocations, {
blockIdentifier,
skipValidate: skipValidate,
});
}
To Reproduce
trigger estimateFeeBulk
Expected behavior
RPC request should include signature
Desktop (please complete the following information):
- Node version: 18.18.2
- Starknet.js version: 6.6.0
- Network [devnet, testnet]: testnet
Metadata
Metadata
Assignees
Labels
Type: bugSomething isn't workingSomething isn't working