Skip to content

Conversation

@francesco-stacks
Copy link

@francesco-stacks francesco-stacks commented Nov 6, 2025

Description

82/98 StaticCheckErrorKind variants covered.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 6, 2025
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ brice-stacks
✅ wileyj
✅ jacinta-stacks
✅ rob-stacks
✅ federico-stacks
✅ Jiloc
✅ obycode
❌ francesco-stacks
You have signed the CLA already but the status is still pending? Let us recheck it.

@francesco-stacks francesco-stacks changed the base branch from aac-client-breaking to develop November 12, 2025 11:15
@francesco-stacks francesco-stacks changed the title feat: add static check error consensus tests feat: add static and runtime check error consensus tests Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 82.51038% with 379 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.51%. Comparing base (62fe5cb) to head (d1ef473).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
clarity-types/src/errors/analysis.rs 68.23% 88 Missing ⚠️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 70.73% 36 Missing ⚠️
...lib/src/chainstate/tests/runtime_analysis_tests.rs 88.18% 28 Missing ⚠️
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 90.33% 26 Missing ⚠️
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 84.93% 25 Missing ⚠️
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 75.96% 25 Missing ⚠️
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 66.17% 23 Missing ⚠️
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 73.01% 17 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs 83.16% 17 Missing ⚠️
clarity-types/src/types/signatures.rs 81.92% 15 Missing ⚠️
... and 20 more

❌ Your project check has failed because the head coverage (75.51%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6661      +/-   ##
===========================================
- Coverage    79.47%   75.51%   -3.96%     
===========================================
  Files          577      578       +1     
  Lines       357469   358657    +1188     
===========================================
- Hits        284089   270846   -13243     
- Misses       73380    87811   +14431     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 75.55% <100.00%> (+0.84%) ⬆️
clarity-types/src/tests/types/mod.rs 83.62% <ø> (-13.25%) ⬇️
clarity/src/vm/analysis/read_only_checker/tests.rs 100.00% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/mod.rs 100.00% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs 85.42% <ø> (ø)
...ity/src/vm/analysis/type_checker/v2_05/contexts.rs 98.24% <100.00%> (ø)
...c/vm/analysis/type_checker/v2_05/natives/assets.rs 98.04% <100.00%> (+0.18%) ⬆️
...src/vm/analysis/type_checker/v2_05/natives/maps.rs 95.57% <100.00%> (+0.24%) ⬆️
...src/vm/analysis/type_checker/v2_05/tests/assets.rs 99.49% <100.00%> (ø)
.../vm/analysis/type_checker/v2_05/tests/contracts.rs 81.98% <100.00%> (-17.60%) ⬇️
... and 44 more

... and 218 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fe5cb...d1ef473. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants