Added tenure size checker/limiter

[rdeioris]

Description

This patch introduces monitoring and limiting for the size of a whole tenure. Note that tenure extend resets the counter.

For allowing more targeted tests, it introduces a config option for the miner (not exposed to the file based configuration) for enabling logging of skipped transactions (that are not logged or sent to the event system).

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[obycode]

Added some comments for improvements.

One thing I think it missing is an update to the code where the miner decides whether or not it should attempt to tenure extend, see stacks-node/src/nakamoto_node/miner.rs:1676

                // Do not extend if we have spent < 50% of the budget, since it is
                // not necessary.
                let usage = self
                    .tenure_budget
                    .proportion_largest_dimension(&self.tenure_cost);
                if usage < self.config.miner.tenure_extend_cost_threshold {
                    return Ok(NakamotoTenureInfo {
                        coinbase_tx: None,
                        tenure_change_tx: None,
                    });
                }

I think it should also attempt to extend if the size is >50% of the budget.

[obycode]

These skipped events might be nice for the explorer to show why a transaction is not being picked up. We might want to consider passing this option through the config file. If we don't do that, and only allow it to be set in tests, then why don't we remove this field from MinerConfigFile? My preference would be to support setting it in the config file.

[rdeioris]

I already have it in another patch. But actually it is pretty tiny, so i can definitely include it in this one.

[obycode]

Can you add a test to verify that the size can grow after a time-based tenure extend?

[jcnelson]

I'm not seeing the code where the miner checks max_tenure_size to stop mining blocks?

[rdeioris]

I'm not seeing the code where the miner checks max_tenure_size to stop mining blocks?

I did it for allowing smaller transactions to be included (given that the check is done at transaction inclusion). The only case I see for completely disabling block mining is if the current tenure size is so near to the limit that it is impossibile for any transaction to be included

[rdeioris]

Added some comments for improvements.

One thing I think it missing is an update to the code where the miner decides whether or not it should attempt to tenure extend, see stacks-node/src/nakamoto_node/miner.rs:1676

                // Do not extend if we have spent < 50% of the budget, since it is
                // not necessary.
                let usage = self
                    .tenure_budget
                    .proportion_largest_dimension(&self.tenure_cost);
                if usage < self.config.miner.tenure_extend_cost_threshold {
                    return Ok(NakamotoTenureInfo {
                        coinbase_tx: None,
                        tenure_change_tx: None,
                    });
                }

I think it should also attempt to extend if the size is >50% of the budget.

Love it, working on it

[jcnelson]

Looks like CI is still failing