Skip to content

Draft: re-attempt mining after blocking_signal flaps #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Draft: re-attempt mining after blocking_signal flaps #3609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c51e0c4
fix: re-attempt mining after blocking_signal flaps
Mar 13, 2023
2243386
Merge branch 'master' into fix/miner-blocking-flap
Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 60 additions & 65 deletions testnet/stacks-node/src/neon_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,77 +1894,72 @@ impl BlockMinerThread {
);

// build the block itself
let (anchored_block, _, _) = match StacksBlockBuilder::build_anchored_block(
&chain_state,
&burn_db.index_conn(),
&mut mem_pool,
&parent_block_info.stacks_parent_header,
parent_block_info.parent_block_total_burn,
vrf_proof.clone(),
mblock_pubkey_hash,
&coinbase_tx,
self.config.make_block_builder_settings(
attempt,
false,
self.globals.get_miner_status(),
),
Some(&self.event_dispatcher),
) {
Ok(block) => block,
Err(ChainstateError::InvalidStacksMicroblock(msg, mblock_header_hash)) => {
// part of the parent microblock stream is invalid, so try again
info!("Parent microblock stream is invalid; trying again without the offender {} (msg: {})", &mblock_header_hash, &msg);

// truncate the stream
parent_block_info.stacks_parent_header.microblock_tail = match microblocks_opt {
Some(microblocks) => {
let mut tail = None;
for mblock in microblocks.into_iter() {
if mblock.block_hash() == mblock_header_hash {
break;
let mut retry_count = 0;
let anchored_block = loop {
match StacksBlockBuilder::build_anchored_block(
&chain_state,
&burn_db.index_conn(),
&mut mem_pool,
&parent_block_info.stacks_parent_header,
parent_block_info.parent_block_total_burn,
vrf_proof.clone(),
mblock_pubkey_hash,
&coinbase_tx,
self.config.make_block_builder_settings(
attempt,
false,
self.globals.get_miner_status(),
),
Some(&self.event_dispatcher),
) {
Ok((block, _, _)) => {
break block;
}
Err(ChainstateError::InvalidStacksMicroblock(msg, mblock_header_hash)) => {
// part of the parent microblock stream is invalid, so try again
info!("Parent microblock stream is invalid; trying again without the offender {} (msg: {})", &mblock_header_hash, &msg);

// truncate the stream
parent_block_info.stacks_parent_header.microblock_tail = match microblocks_opt {
Some(ref microblocks) => {
let mut tail = None;
for mblock in microblocks.clone().into_iter() {
if mblock.block_hash() == mblock_header_hash {
break;
}
tail = Some(mblock);
}
tail = Some(mblock);
}
if let Some(ref t) = &tail {
debug!(
"New parent microblock stream tail is {} (seq {})",
t.block_hash(),
t.header.sequence
);
if let Some(ref t) = &tail {
debug!(
"New parent microblock stream tail is {} (seq {})",
t.block_hash(),
t.header.sequence
);
}
tail.map(|t| t.header)
}
tail.map(|t| t.header)
}
None => None,
};
None => None,
};

// try again
match StacksBlockBuilder::build_anchored_block(
&chain_state,
&burn_db.index_conn(),
&mut mem_pool,
&parent_block_info.stacks_parent_header,
parent_block_info.parent_block_total_burn,
vrf_proof.clone(),
mblock_pubkey_hash,
&coinbase_tx,
self.config.make_block_builder_settings(
attempt,
false,
self.globals.get_miner_status(),
),
Some(&self.event_dispatcher),
) {
Ok(block) => block,
Err(e) => {
error!("Relayer: Failure mining anchor block even after removing offending microblock {}: {}", &mblock_header_hash, &e);
// try again
retry_count += 1;
}
Err(ChainstateError::MinerAborted) => {
if retry_count >= 5 {
warn!("Miner aborted tenure because miner was blocked on 5 attempts");
return None;
}
retry_count += 1;
let retry_time = 2u64.saturating_pow(retry_count);
let retry_time = if retry_time > 30 { 300 } else { retry_time };
info!("Miner blocked and aborted tenure, will try again"; "retry_time_secs" => retry_time);
thread::sleep(Duration::from_secs(retry_time));
}
}
Err(e) => {
error!("Relayer: Failure mining anchored block: {}", e);
return None;
}
Err(e) => {
error!("Relayer: Failure mining anchored block: {}", e);
return None;
}
};
};

info!(
Expand Down