-
Notifications
You must be signed in to change notification settings - Fork 168
refactor(tests): remove datamodel helpers for policy and network #17780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor(tests): remove datamodel helpers for policy and network #17780
Conversation
|
Images are ready for the commit at c37d4fc. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17780 +/- ##
=======================================
Coverage 49.17% 49.18%
=======================================
Files 2729 2729
Lines 200890 200850 -40
=======================================
Hits 98789 98789
+ Misses 94370 94328 -42
- Partials 7731 7733 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
98a8614 to
c37d4fc
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@rhybrillou: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Cleaning up use and generation of
CreateTableAndNewStoreandDestroyfunction in postgres stores.The
pgtest.ForTutility does the job of providing a database with an up-to-date datamodel.PR stack
User-facing documentation
is updated ORupdate is not neededis created and is linked above ORis not neededTesting and quality
Automated testing
How I validated my change
manual unit test run