Skip to content

Conversation

@rhybrillou
Copy link
Contributor

@rhybrillou rhybrillou commented Nov 12, 2025

Description

Cleaning up use and generation of CreateTableAndNewStore and Destroy function in postgres stores.
The pgtest.ForT utility does the job of providing a database with an up-to-date datamodel.

PR stack

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

manual unit test run

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 12, 2025

Images are ready for the commit at c37d4fc.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-337-gc37d4fc9b3.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.18%. Comparing base (2d3aaf4) to head (c37d4fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17780   +/-   ##
=======================================
  Coverage   49.17%   49.18%           
=======================================
  Files        2729     2729           
  Lines      200890   200850   -40     
=======================================
  Hits        98789    98789           
+ Misses      94370    94328   -42     
- Partials     7731     7733    +2     
Flag Coverage Δ
go-unit-tests 49.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhybrillou
Copy link
Contributor Author

/retest

Base automatically changed from master-yann/pgstore_explicit_datamodel_generation_helpers to master November 13, 2025 14:12
@rhybrillou rhybrillou requested a review from a team as a code owner November 13, 2025 14:12
@rhybrillou rhybrillou force-pushed the master-yann/pgstore_no_datamodel_helper_for_policy_and_network branch from 98a8614 to c37d4fc Compare November 13, 2025 14:23
@rhybrillou
Copy link
Contributor Author

/retest

2 similar comments
@rhybrillou
Copy link
Contributor Author

/retest

@rhybrillou
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 14, 2025

@rhybrillou: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-nongroovy-e2e-tests c37d4fc link true /test gke-nongroovy-e2e-tests
ci/prow/ocp-4-20-nongroovy-e2e-tests c37d4fc link false /test ocp-4-20-nongroovy-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests c37d4fc link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants