Skip to content

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Sep 3, 2025

Description

Follow up question from David Caravello at sprint demos about plans for Known To Be Used in Ransomware Campaigns from CISA KEV.

Lean toward the future, although selection and implementation of visual presentation does not imply that ransomware has been added to MVP scope.

See pictures of alternative visual presentations below. We will adjust with guidance from stakeholders.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run start in ui/apps/platform folder with staging demo as central.

Manual testing

Temporarily edit code to display possibilities.

  1. Visit /main/vulnerabilities/all-images

    • No known exploit (no change from demo)
      No_known_exploit

    • Has known exploit but not known to be used in ransomware campaigns (no change from demo)
      One_generic

    • Has known exploit and known to be used in ransomware campaigns

      Most specific label (with parallel wording for ransomware)
      One_parallel

      Both labels (with parallel wording for ransomware)
      Both_parallel

      Both labels (with different wording for ransomware that is similar to CISA KEV catalog)
      https://www.cisa.gov/known-exploited-vulnerabilities-catalog
      Both_different

@pedrottimark pedrottimark requested a review from a team as a code owner September 3, 2025 01:09
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 2cb8bca.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-654-g2cb8bcac39.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.65%. Comparing base (5d95272) to head (2cb8bca).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16641      +/-   ##
==========================================
- Coverage   48.73%   48.65%   -0.08%     
==========================================
  Files        2659     2659              
  Lines      198500   198828     +328     
==========================================
+ Hits        96732    96743      +11     
- Misses      94183    94497     +314     
- Partials     7585     7588       +3     
Flag Coverage Δ
go-unit-tests 48.65% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants