schema and config changes for vMCP: Composition - Output Aggregation #2609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrobla
changed the title
…for Multi-Step Workflows Successfully added the OutputFormat / outputFormat field to all configuration layers for vMCP composite tool workflows. This PR lays the foundation for implementing output aggregation in multi-step workflows as described in issue #174.
yrobla
force-pushed
the
feat/vmcp_composition_multistep
branch
from
d30b42b to
09c8ef4
Compare
Copilot finished reviewing on behalf of
yrobla
November 17, 2025 14:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the OutputFormat / output_format field across all configuration layers for vMCP composite tool workflows, laying the groundwork for implementing output aggregation in multi-step workflows (issue #174).
- Added
OutputFormatstring field to theWorkflowDefinitionstruct in the composer package - Added
OutputFormatfield to theCompositeToolConfigstruct in the config package with JSON/YAML tags - Updated the workflow converter to map
OutputFormatfrom config to workflow definitions - Added comprehensive test coverage for the OutputFormat field conversion
- Updated Kubernetes CRD definitions to include the
outputFormatfield - Updated API documentation to describe the new field
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/vmcp/composer/composer.go | Added OutputFormat field to WorkflowDefinition struct with detailed documentation |
| pkg/vmcp/config/config.go | Added OutputFormat field to CompositeToolConfig with JSON/YAML tags and comprehensive documentation |
| pkg/vmcp/server/workflow_converter.go | Updated converter to map OutputFormat from config to WorkflowDefinition |
| pkg/vmcp/server/workflow_converter_test.go | Added test coverage for OutputFormat field propagation through conversion |
| cmd/thv-operator/api/v1alpha1/virtualmcpcompositetooldefinition_types.go | Added OutputFormat field to CRD spec with kubebuilder annotations |
| deploy/charts/operator-crds/crds/toolhive.stacklok.dev_virtualmcpcompositetooldefinitions.yaml | Updated CRD schema with outputFormat field definition |
| docs/operator/crd-api.md | Updated API documentation to include outputFormat field description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
==========================================
- Coverage 55.85% 55.84% -0.01%
==========================================
Files 312 312
Lines 29541 29542 +1
==========================================
- Hits 16501 16499 -2
- Misses 11599 11601 +2
- Partials 1441 1442 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgrunnagle
approved these changes
Nov 17, 2025
Contributor
tgrunnagle
left a comment
tgrunnagle
left a comment
There was a problem hiding this comment.
A future enhancement may be to add support for configRefs in k8s.
jhrozek
reviewed
Nov 17, 2025
| description: A Helm chart for installing the ToolHive Operator CRDs into Kubernetes. | ||
| type: application | ||
| version: 0.0.57 | ||
| version: 0.0.58 |
Contributor
There was a problem hiding this comment.
I think 0.0.58 was merged in the meantime and we need another bump
jhrozek
reviewed
Nov 17, 2025
| // } | ||
| // | ||
| // +optional | ||
| OutputFormat string `json:"outputFormat,omitempty"` |
Contributor
There was a problem hiding this comment.
Should we add a size limit?
Since we already have a webhook could we add some validation there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully added the OutputFormat / outputFormat field to all configuration layers for vMCP composite tool workflows. This PR lays the foundation for implementing output aggregation in multi-step workflows as described in issue #174.