refactor: Separate interfaces from implementation for container runtime #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJBurns
approved these changes
Mar 26, 2025
This creates a `runtime` package, which defines the interfaces to be implemented for a runtime. Then we have `docker` which is the one implementation we have today. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
separate-interfaces
branch
from
d59c16e to
d8e85d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
runtimepackage, which defines the interfaces to beimplemented for a runtime.
Then we have
dockerwhich is the one implementation we have today.Signed-off-by: Juan Antonio Osorio [email protected]