Implement secrets management #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
secret-interface
branch
2 times, most recently
from
056c350 to
f01b665
Compare
Implements a set of secrets management commands, along with a flag for `run` which allows secrets to be injected as environment variables. Note that this implementation stores the secrets to an unencrypted file on disk. This will be changed in an upcoming PR. Example of use: ``` $ bin/vt secret list Available secrets: - fizz - foo $ bin/vt run --secret=foo,target=FOO --secret=fizz,target=FIZZ alpine -- env Logging to: /tmp/vibetool-alpine.log MCP server alpine-1742982443 is running in the background (PID: 18425) Use 'vibetool stop alpine-1742982443' to stop the server $ docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES ed1bda951b03 alpine "env" About a minute ago Exited (0) About a minute ago alpine-1742982443 $ docker logs ed1bda951b03 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOSTNAME=ed1bda951b03 FOO=bar FIZZ=buzz MCP_TRANSPORT=stdio HOME=/root ```
JAORMX
approved these changes
Mar 26, 2025
| rootCmd.AddCommand(rmCmd) | ||
| rootCmd.AddCommand(proxyCmd) | ||
| rootCmd.AddCommand(versionCmd) | ||
| rootCmd.AddCommand(newSecretCommand()) |
Collaborator
There was a problem hiding this comment.
Yeah... we should probably change the rest of the commands to do something like this. (not for this PR)
| type BasicManager struct { | ||
| filePath string | ||
| secrets map[string]string | ||
| mu sync.RWMutex // Protects concurrent access to secrets map |
Collaborator
There was a problem hiding this comment.
nit: https://github.com/puzpuzpuz/xsync could be handy for having a thread safe map implementation so no mutex would need to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a set of secrets management commands, along with a flag for
runwhich allows secrets to be injected as environment variables.Note that this implementation stores the secrets to an unencrypted file
on disk. This will be changed in an upcoming PR.
Example of use: