Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Nov 20, 2025

Also support two separate DB users: A migration user, and a regular user.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 23.25581% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.56%. Comparing base (4ffe3f6) to head (fc4400f).

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   67.19%   66.56%   -0.63%     
==========================================
  Files          60       60              
  Lines        3707     3742      +35     
==========================================
  Hits         2491     2491              
- Misses       1062     1096      +34     
- Partials      154      155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmjb dmjb force-pushed the migrate-on-startup branch from 2fedec4 to f776c91 Compare November 20, 2025 12:05
@dmjb dmjb force-pushed the migrate-on-startup branch from 0be59c6 to a424ce8 Compare November 24, 2025 09:30
dmjb and others added 4 commits November 25, 2025 15:50
Also support two separate DB users: A migration user, and a regular
user.
Also, fixed bug in handler.
@blkt blkt force-pushed the migrate-on-startup branch from 762960f to fc4400f Compare November 25, 2025 15:45
@blkt
Copy link
Contributor

blkt commented Nov 25, 2025

I did the following to ensure that everything was working fine

  • added a test running the migration process as serve subcommand does concurrently a bunch of times (default is 3 for the test, I ran 100 parallel instances of it and none failed)
  • manually tested by running 10 instances of the process at the same time providing the same configuration (except for the address)
  • changed the migration so that tests failed to ensure that they were successfully catching weird scenarios (they do)
  • document the sole assumptions we make about what the DB/Infra admin needs to provide in README.md

@blkt blkt merged commit 9ac03a6 into main Nov 25, 2025
11 checks passed
@blkt blkt deleted the migrate-on-startup branch November 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants