fix: correct problems with ollama and aider #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aponcedeleonch
approved these changes
Jan 15, 2025
|
This resolved the errors I saw with Ollama, however I get pretty unexpected results: 
|
danbarr
previously requested changes
Jan 15, 2025
It has a pair of problems: - always need to check that the model contains some value - only send chunks that contain data, and do not send double newlines as they get considered as a different chunk Closes: #586
Note that if you're running from source, the full malicious database is not available, that's only added when producing the release image. Only packages from https://github.com/stacklok/codegate/blob/main/data/malicious.jsonl and other files in that directory are. |
|
rebased on top of latest patches, and testing again |
yrobla
dismissed
danbarr’s stale review
please test again, using --model ollama_chat/qwen2.5-coder:7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has a pair of problems:
Closes: #586