fix: incorrect datetime format for strftime() in windows #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datetime format passed to Structlog's configuration inside setup_logging() in src/codegate/codegate_logging.py works on Linux but returns an error on Windows. Changed the datetime format so it works on Linux as well as Windows.
lukehinds
approved these changes
Jan 13, 2025
|
@protokoul this will ship in the next release coming today |
|
Thank you @lukehinds. This is awesome 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datetime format used with Structlog's configuration inside
setup_logging()insrc/codegate/codegate_logging.pyis passed tostrftime(), which works on Linux but returns an error on Windows. Changed the datetime format so it works on Linux as well as Windows.Resolves #556