Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

yrobla
Copy link
Contributor

@yrobla yrobla commented Dec 10, 2024

Right now the only url that could be parameterized is VLLM_URL. Expose the other urls as well so they can be customized

Closes: #243

Right now the only url that could be parameterized is VLLM_URL. Expose
the other urls as well so they can be customized

Closes: #243
Copy link
Contributor

@ptelang ptelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, can you add logformat as well?

@yrobla yrobla requested a review from ptelang December 10, 2024 16:23
Copy link
Contributor

@ptelang ptelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yrobla yrobla merged commit 1417112 into main Dec 10, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose all configuration parameters in docker image
2 participants