feat: add stacklet_platform data source #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertodonato
force-pushed
the
ack/platform-data-source
branch
8 times, most recently
from
821027a to
d1dd177
Compare
### what add a datasource to retrieve general details about the platform ### why provide general info about the deployment ### testing acceptance tests and tested in sandbox ### docs added here
albertodonato
force-pushed
the
ack/platform-data-source
branch
3 times, most recently
from
5baa432 to
79c550b
Compare
albertodonato
force-pushed
the
ack/platform-data-source
branch
from
79c550b to
05c6d89
Compare
fwereade
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
LGTM, thanks, although I'm not sure the default_role is a concept we still want to be using/advertising/encouraging? I expect @howbazaar or @wgrant would know for sure
docs/data-sources/platform.md
Outdated
|
|
||
| - `aws_account_customer_config` (Attributes) Customer configuration for AWS accounts. (see [below for nested schema](#nestedatt--aws_account_customer_config)) | ||
| - `aws_org_read_customer_config` (Attributes) Customer configuration for AWS organization read access. (see [below for nested schema](#nestedatt--aws_org_read_customer_config)) | ||
| - `default_role` (String) Default role for users. |
There was a problem hiding this comment.
I think this could either use a little more explanation or perhaps just be dropped? I'm not sure it's really a meaningful concept any more with the rbac work…
|
yeah I'm removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
add a datasource to retrieve general details about the platform
why
provide general info about the deployment
testing
acceptance tests and tested in sandbox
docs
added here