Skip to content

feat: add volume backup waiter #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 5, 2025
Merged

feat: add volume backup waiter #2669

merged 10 commits into from
Jun 5, 2025

Conversation

@Benjosh95
Copy link
Contributor

@Benjosh95 Benjosh95 commented Jun 1, 2025 •
edited
Loading

Description

This PR creates the waiters (creation, Deletion, Restoring) to complete the volume backup api onboarding.

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
Copy link
Member

rubenhoenle commented Jun 2, 2025

Please adjust the changelogs as described in the PR template

rubenhoenle
rubenhoenle reviewed Jun 2, 2025
View reviewed changes
@Benjosh95 Benjosh95 marked this pull request as ready for review June 2, 2025 17:14
@Benjosh95 Benjosh95 requested review from Fyusel and marceljk as code owners June 2, 2025 17:14
@Benjosh95 Benjosh95 mentioned this pull request Jun 2, 2025
Merged
7 tasks
@rubenhoenle rubenhoenle mentioned this pull request Jun 4, 2025
Closed
10 tasks
Fyusel
Fyusel reviewed Jun 4, 2025
View reviewed changes
@Benjosh95 Benjosh95 force-pushed the feat/stackitsdk-145-iaas-backup branch from 84ea54a to 8f83e7c Compare June 5, 2025 11:44
@Fyusel Fyusel removed the conflict label Jun 5, 2025
@Benjosh95 Benjosh95 merged commit 34b4658 into main Jun 5, 2025
8 checks passed
@Benjosh95 Benjosh95 deleted the feat/stackitsdk-145-iaas-backup branch June 5, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle left review comments

@Fyusel Fyusel Fyusel approved these changes

@marceljk marceljk Awaiting requested review from marceljk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Benjosh95 @rubenhoenle @Fyusel