-
Notifications
You must be signed in to change notification settings - Fork 10.1k
feat: web search feature #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: web search feature #1703
Conversation
|
web search to convert a URL into apps |
|
Theres a few conflicts here @migavel508 if you could resolve these please, Awesome feature though and great work on a highly requested feature. Thanks. |
sure @xKevIsDev let me resolve it immediately |
5376b9e to
beedd3f
Compare
|
Hi, Can you check to resolve the issues so we can proceed with the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both api-web-search.ts and web-search.ts are doing the same job fetching a list of search results (title, content, and URL).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keshav2800 good spot. @migavel508 I think you delete the "api" folder and this file.
Then rename api-web-search.ts to api.web-search.ts so you follow the pattern other routes use.
Double-check your WebSearch.client is calling this route, and that the payload sent matches what the client expects.
Great work btw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just needs a minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keshav2800 good spot. @migavel508 I think you delete the "api" folder and this file.
Then rename api-web-search.ts to api.web-search.ts so you follow the pattern other routes use.
Double-check your WebSearch.client is calling this route, and that the payload sent matches what the client expects.
Great work btw!
|
Sure , let me fix it now
…On Sun, 26 Oct 2025 at 3:19 AM, Richard McSharry | Code Monkey < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Good job, just needs a minor change.
------------------------------
On app/routes/api/web-search.ts
<#1703 (comment)>
:
@keshav2800 <https://github.com/keshav2800> good spot. @migavel508
<https://github.com/migavel508> I think you delete the "api" folder and
this file.
Then rename api-web-search.ts to api.web-search.ts so you follow the
pattern other routes use.
Double-check your WebSearch.client is calling this route, and that the
payload sent matches what the client expects.
Great work btw!
—
Reply to this email directly, view it on GitHub
<#1703 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6HAE7X5OZ5PZAEP3PPWN7D3ZPV6RAVCNFSM6AAAAAB5CRF7OCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOBQGI2TEMZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.