Skip to content

Conversation

@migavel508
Copy link

No description provided.

@migavel508 migavel508 closed this May 14, 2025
@migavel508 migavel508 reopened this May 14, 2025
@migavel508
Copy link
Author

web search to convert a URL into apps

@migavel508 migavel508 closed this May 14, 2025
@migavel508 migavel508 reopened this May 14, 2025
@xKevIsDev xKevIsDev changed the title Web search feature feat: web search feature May 15, 2025
@xKevIsDev
Copy link
Collaborator

Theres a few conflicts here @migavel508 if you could resolve these please,

Awesome feature though and great work on a highly requested feature. Thanks.

@migavel508
Copy link
Author

Theres a few conflicts here @migavel508 if you could resolve these please,

Awesome feature though and great work on a highly requested feature. Thanks.

sure @xKevIsDev let me resolve it immediately

@migavel508 migavel508 force-pushed the web-search-feature branch from 5376b9e to beedd3f Compare June 18, 2025 18:31
@Stijnus Stijnus self-assigned this Aug 29, 2025
@Stijnus
Copy link
Collaborator

Stijnus commented Aug 30, 2025

Hi, Can you check to resolve the issues so we can proceed with the PR?

@Stijnus Stijnus self-requested a review September 17, 2025 11:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both api-web-search.ts and web-search.ts are doing the same job fetching a list of search results (title, content, and URL).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav2800 good spot. @migavel508 I think you delete the "api" folder and this file.

Then rename api-web-search.ts to api.web-search.ts so you follow the pattern other routes use.

Double-check your WebSearch.client is calling this route, and that the payload sent matches what the client expects.

Great work btw!

Copy link

@rmcsharry rmcsharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just needs a minor change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav2800 good spot. @migavel508 I think you delete the "api" folder and this file.

Then rename api-web-search.ts to api.web-search.ts so you follow the pattern other routes use.

Double-check your WebSearch.client is calling this route, and that the payload sent matches what the client expects.

Great work btw!

@migavel508
Copy link
Author

migavel508 commented Oct 26, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants