Skip to content

ci: Fix demo image build workflows #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025
Merged

ci: Fix demo image build workflows #212

merged 7 commits into from
May 8, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented May 7, 2025

This PR fixes and improves the demo images:

  • Push the images into a separate Harbor project (namespace)
  • Use a re-usable workflow
  • Harden the workflows
  • Bump the actions
  • Remove unused workflow

Successful workflow runs:

@Techassi Techassi self-assigned this May 7, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering May 7, 2025
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 7, 2025
@Techassi Techassi changed the title ci: Fix demo images ci: Fix demo image build workflows May 7, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review May 7, 2025 11:09
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 7, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just raised a question about the unused workflow.

@Techassi Techassi added this pull request to the merge queue May 8, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering May 8, 2025
Merged via the queue into main with commit fe60a2c May 8, 2025
2 checks passed
@Techassi Techassi deleted the ci/fix-demo-images branch May 8, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants