Skip to content

feat(run-openshift-preflight): Print preflight log #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techassi merged 1 commit into from
Sep 9, 2025
Merged

feat(run-openshift-preflight): Print preflight log #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions run-openshift-preflight/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@ runs:
else
echo "Checks failed"
cat preflight.out
cat preflight.log
Copy link
Member

@NickLarsenNZ NickLarsenNZ Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to send it to $GITHUB_OUTPUT GITHUB_STEP_SUMMARY.

Copy link
Member Author

@Techassi Techassi Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could provide outputs, but currently there is no other action/job which consumes this.

Copy link
Member Author

@Techassi Techassi Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GITHUB_STEP_SUMMARY

Ah well. That could also be nice. But I honestly don't know how good it would look as it is not Markdown.

Copy link
Member

@NickLarsenNZ NickLarsenNZ Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is markdown

Copy link
Member Author

@Techassi Techassi Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how good it would look as it is not Markdown

Here, it refers to the preflight.log data.

exit 1
fi