Skip to content

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Aug 28, 2025

The official terms are:

  • Image Index (Manifest): An OCI image index manifest which points to one or more image manifests.
  • Image Manifest: An OCI image manifest per platform

See the spec.

flowchart TB
    ii["
        sdp/kafka:1.2.3-stackable25.7.0 
        (Image Index Manifest)"]
    im-1["
        sdp/kafka:1.2.3-stackable25.7.0-amd64
        (Image Manifest)"]
    im-2["
        sdp/kafka:1.2.3-stackable25.7.0-arm64
        (Image Manifest)"]

    ii -- contains --> im-1
    ii -- contains --> im-2
Loading

@Techassi Techassi self-assigned this Aug 28, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Aug 28, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 28, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 28, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was with intent that I suffixed those with "manifest", because they are, by the specs definition of manifest.

But, if you need it to match the spec, I guess go for it, but it makes me uncomfortable and I think it is an unnecessary change.

@Techassi
Copy link
Member Author

Techassi commented Aug 28, 2025

Man, I hate everything about this. The spec is a joke.

I will revert the rename (and opt for a better action name: publish-image-index-manifest), but will keep the new output.

@Techassi Techassi changed the title refactor!: Rename image index manifest to image index refactor!: Rename action to publish-image-index-manifest Aug 28, 2025
@Techassi Techassi requested a review from NickLarsenNZ August 28, 2025 12:17
@Techassi Techassi force-pushed the chore/rename-index-manifest branch from 77a6548 to d80faca Compare August 28, 2025 12:57
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 2f1efd2 into main Aug 28, 2025
10 checks passed
@Techassi Techassi deleted the chore/rename-index-manifest branch August 28, 2025 13:02
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Aug 28, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants