-
Notifications
You must be signed in to change notification settings - Fork 8
Improve collection matching and upload options #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve collection matching and upload options #176
Conversation
ircwaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- required either collection_matchers or legacy collection mapping to be non-empty. this is not backwards compatible as existing payloads do not require any collection matching/mapping configuration.
jkeifer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments that could result in changes if you so choose, but I am satisfied with the current state of everything (note: it was a bit hard to review all the changes because it looks like you pulled in a bunch of ruff rules that touched a lot of code 😅). Nothing I mentioned is really a deal breaker so do as you choose.
Summary:
uvand updates CI and pre-commit. It also makes some extensive changes and additions to the README, gets readthedocs working, and makes a minimal changeset to the readthedocs content.Related Issue(s):
Proposed Changes:
Payloadclass.collection_matchersarray to the payloadprocessblock. Mutually exclusive with the legacyprocess.upload_options.collectionsmap. This supports deterministic order in the pattern matching and directly supports a "catch_all" matcher, which is a common need.collection_optionsmap to the payloadprocessblock. Supports collection-specificupload_options, with a fallback to the globalprocess.upload_optionsif a collection is not found in the map.PR Checklist: