update type informations #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
force-pushed
the
patch/better-type-definition
branch
from
c37efdb to
5c3e8bf
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 5c3e8bf | Previous: accd079 | Ratio |
|---|---|---|---|
Items With Model validation (200) |
52.668191618067624 iter/sec (stddev: 0.017704517595354557) |
77.87066395082641 iter/sec (stddev: 0.006931495516767795) |
1.48 |
Items With Model validation (1000) |
12.706291671750572 iter/sec (stddev: 0.024122609009922084) |
16.686496976926502 iter/sec (stddev: 0.013868170627739857) |
1.31 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why
pre-commitwasn't getting those errorsI had to run
uv run --with mypy mypy -p stac_fastapito get the error fixed with this PR