Skip to content

Conversation

@l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 3, 2021

Related Issue(s): N/A

Description:

  • Avoids breakage in case of incompatible third party upgrades
  • Improves consistency between builds

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@l0b0 l0b0 force-pushed the freeze-python-dependencies branch from 907ce1f to e273ed0 Compare June 3, 2021 21:27
@duckontheweb duckontheweb mentioned this pull request Jun 4, 2021
4 tasks
Based on `pip freeze`.

- Avoids breakage in case of incompatible third party upgrades
- Improves consistency between builds
@l0b0 l0b0 force-pushed the freeze-python-dependencies branch from e273ed0 to 7f75df6 Compare June 5, 2021 05:32
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but it I'll wait until after you've had a chance to integrate the changes from #361 to approve and merge.

@l0b0
Copy link
Contributor Author

l0b0 commented Jun 7, 2021

Looks like this change might be superseded by the Dependabot PRs.

@duckontheweb
Copy link
Contributor

Yes, I think so. I ended up consolidating those PRs into #424. That PR removes sphinx-autobuild and pylint, since we don't appear to use those in the CI. Once that PR is merged we can close this if everything is covered.

@l0b0 l0b0 closed this Jun 9, 2021
@l0b0 l0b0 deleted the freeze-python-dependencies branch June 9, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants